Bugzilla – Attachment 33667 Details for
Bug 10956
Series of OPAC searches can cause a browser crash
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[HACK] Bug 10956 - Series of OPAC searches can cause a browser crash
HACK-Bug-10956---Series-of-OPAC-searches-can-cause.patch (text/plain), 1.35 KB, created by
Marc Véron
on 2014-11-18 19:31:04 UTC
(
hide
)
Description:
[HACK] Bug 10956 - Series of OPAC searches can cause a browser crash
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2014-11-18 19:31:04 UTC
Size:
1.35 KB
patch
obsolete
>From 47dcd35d234db791fc8a5c473004ce57dec77e19 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Tue, 18 Nov 2014 20:24:42 +0100 >Subject: [PATCH] [HACK] Bug 10956 - Series of OPAC searches can cause a > browser crash > >This is a hack to track down the issue with an endless loop while highlighting words. >I changed function innerHighlight(node, pat) to break out of loop after a while. >With this hack I can no longer reproduce the bug. > >It is not a solution, but it could help to track down the problem. >--- > .../opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-3.js | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-3.js b/koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-3.js >index 69bb52d..4538f62 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-3.js >+++ b/koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-3.js >@@ -33,6 +33,9 @@ jQuery.fn.highlight = function(pat) { > else if (node.nodeType == 1 && node.childNodes && !/(script|style)/i.test(node.tagName)) { > for (var i = 0; i < node.childNodes.length; ++i) { > i += innerHighlight(node.childNodes[i], pat); >+ // HACK FOR TESTING BUG 10956 >+ // Break out of loop with huge i >+ if (i > 400) break; > } > } > return skip; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10956
:
33662
|
33667
|
33673
|
33674
|
33897
|
33903