From aa8e396961d63da85d3b137bde2e9157280e2ed5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc=20V=C3=A9ron?= Date: Wed, 19 Nov 2014 10:20:04 +0100 Subject: [PATCH] Bug 10956 - Series of OPAC searches can cause a browser crash Solution: Prevent jQuery.fn.highlight = function(pat) to be called with empty pat by skipping empty values in highlight loop. To test: Without patch, do a search as in comment #1 odr #3 Result: Endless loop (Script not responding) Appply patch: No endless loop, page displays OK --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt index e641d76..4881887 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -1345,6 +1345,9 @@ var x; for (x in q_array) { q_array[x] = q_array[x].replace(/\w*:([\w])/, "$1"); + if (q_array[x].length == 0) { + continue; + } q_array[x] = q_array[x].toLowerCase(); var myStopwords = "[% Koha.Preference('NotHighlightedWords') %]".toLowerCase().split('|'); if( $.inArray(q_array[x], myStopwords) == -1 ) { -- 1.7.10.4