From d9d10fd7a3887ce5e4b4011c5e46d6922cfad745 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 18 Nov 2014 10:42:32 -0500 Subject: [PATCH] [PASSED QA] Bug 12701 - OPAC reading history still accessible by URL if turned OFF If the opacreadinghistory system preference is turned off it is still possible to navigate directly to the OPAC reading history page if you know the URL. This patch adapts the fix for Bug 10595 (OpacTopissue page still accessible when system preference is turned off) for opac-readingrecord.pl To test, log in to the OPAC and test the following conditions: - With opacreadinghistory, navigating directly to /cgi-bin/koha/opac-readingrecord.pl should trigger a 404 error. - With opacreadinghistory turned on there should be a working link to "your reading history" in the left-hand sidebar menu. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer Works as described and passes tests. --- opac/opac-readingrecord.pl | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/opac/opac-readingrecord.pl b/opac/opac-readingrecord.pl index 6e38cfd..1fc0dbc 100755 --- a/opac/opac-readingrecord.pl +++ b/opac/opac-readingrecord.pl @@ -33,6 +33,13 @@ use C4::Output; use C4::Charset qw(StripNonXmlChars); my $query = new CGI; + +# if opacreadinghistory is disabled, leave immediately +if ( ! C4::Context->preference('opacreadinghistory') ) { + print $query->redirect("/cgi-bin/koha/errors/404.pl"); + exit; +} + my ( $template, $borrowernumber, $cookie ) = get_template_and_user( { template_name => "opac-readingrecord.tt", -- 1.9.1