From b80d58a094afe49fd0e4f662fb946d9a7f0743ef Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Wed, 19 Nov 2014 16:55:27 +0100 Subject: [PATCH] Bug 13305: Fix tab order on three item editor forms Content-Type: text/plain; charset=utf-8 While working on bug 10480, I stumbled over the tab order on the forms serials-edit, acqui/addorderiso2709 and services/itemrecorddisplay. They all depend on C4::Items::PrepareItemrecordDisplay. Most of the inputs get a tabindex=1, but some don't. This creates a rather weird tab order for keyboard users (like me). By adjusting one input from C4::Items and the select in those three templates, the tab order is fixed. Test plan: [1] Set system preference AcqCreateItem to "placing an order". [2] Tab through the item fields on addorderiso2709. To do so, go to the Acquisition module, open a basket and add an order from a staged file. Click Add orders, go to Item information. [3] Tab through items fields on services/itemrecorddisplay. You could do this by creating a URL with biblionumber and itemnumber. But you can also test it via Acquisition. The script additem.js calls this perl script to create the item blocks on neworderempty. So again add an order to a basket, but choose for "From a new empty record". [4] Tab through item fields on serials-edit. Go to subscription detail. Click Receive. Choose "Click to add item". (Note that this subscription should create an item record when receiving this serial.) --- C4/Items.pm | 2 +- .../prog/en/modules/acqui/addorderiso2709.tt | 2 +- .../prog/en/modules/serials/serials-edit.tt | 2 +- .../prog/en/modules/services/itemrecorddisplay.tt | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/C4/Items.pm b/C4/Items.pm index 62e89c8..be1ff49 100644 --- a/C4/Items.pm +++ b/C4/Items.pm @@ -3058,7 +3058,7 @@ sub PrepareItemrecordDisplay { # oversize field (textarea) $subfield_data{marc_value} = qq(\n"); } else { - $subfield_data{marc_value} = ""; + $subfield_data{marc_value} = ""; } push( @loop_data, \%subfield_data ); } diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt index cf03b7c..697f92d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt @@ -284,7 +284,7 @@ [% END %] [% IF ( iteminformatio.marc_value.type == 'select' ) %] - [% FOREACH value IN iteminformatio.marc_value.values %] [% IF ( value == iteminformatio.marc_value.default ) %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt index 3877715..d812f11 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt @@ -265,7 +265,7 @@ $(document).ready(function() { [% END %] [% IF ( iteminformatio.marc_value.type == 'select' ) %] - [% FOREACH value IN iteminformatio.marc_value.values %] [% IF ( value == iteminformatio.marc_value.default ) %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt index d55268a..c8657b7 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt @@ -12,7 +12,7 @@ [% END %] [% IF ( iteminfo.marc_value.type == 'select' ) %] - [% FOREACH value IN iteminfo.marc_value.values %] [% IF ( value == iteminfo.marc_value.default ) %] -- 1.7.7.6