Bugzilla – Attachment 33876 Details for
Bug 12123
HTML notices can break the notice viewer
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 12123 - HTML notices can break the notice viewer
SIGNED-OFF-Bug-12123---HTML-notices-can-break-the-.patch (text/plain), 1.76 KB, created by
Owen Leonard
on 2014-11-24 17:45:13 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 12123 - HTML notices can break the notice viewer
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2014-11-24 17:45:13 UTC
Size:
1.76 KB
patch
obsolete
>From 441abda668b580037d87a76185fb390be38e9946 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 22 Apr 2014 06:55:22 -0700 >Subject: [PATCH] [SIGNED-OFF] Bug 12123 - HTML notices can break the notice > viewer >Content-Type: text/plain; charset="utf-8" > >Depending on the content of an html notice, it can cause the notice to >either not be collapsible, be uncollapsible, or to be permanently >collapsed. > >Test Plan: >1) Set your CHECKOUT notice to the following ( with HTML Message checked ) : ><p>The following items have been checked out:</p> > >---- ><blockquote> <<biblio.title>> </blockquote> >---- > ><p>Thank you for visiting the <<branches.branchname>> of HMCPL.</p> >2) Check out some items to a patron >3) View the patrn's notices >4) Note the notice viewer is broken ( message is not collapsed, and > con't be collapsed ). >5) Apply this patch >6) Reload the page >7) Note the notice viewer is no longer broken > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >I followed the test plan successfully. >--- > .../prog/en/modules/members/notices.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt >index 31d40ba..479d629 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt >@@ -56,7 +56,7 @@ > <td> > <a class="notice-title" href="#">[% QUEUED_MESSAGE.subject %]</a> > <p class="notice"> >- [% QUEUED_MESSAGE.content FILTER html_line_break %] >+ <iframe srcdoc="[% QUEUED_MESSAGE.content FILTER html_line_break FILTER html %]"></iframe> > </p> > </td> > <td> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12123
:
27402
|
27403
|
33863
|
33876
|
33882
|
33885
|
33888
|
33950
|
33976
|
73650
|
73758
|
74113
|
74169