Bugzilla – Attachment 33885 Details for
Bug 12123
HTML notices can break the notice viewer
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12123 - [Alternative patch] HTML notices can break the notice viewer
Bug-12123---Alternative-patch-HTML-notices-can-bre.patch (text/plain), 2.20 KB, created by
Liz Rea
on 2014-11-24 23:06:58 UTC
(
hide
)
Description:
Bug 12123 - [Alternative patch] HTML notices can break the notice viewer
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2014-11-24 23:06:58 UTC
Size:
2.20 KB
patch
obsolete
>From 3327ecbe147b33ed285e02c94196f7b07ce56e3c Mon Sep 17 00:00:00 2001 >From: Liz Rea <liz@catalyst.net.nz> >Date: Tue, 25 Nov 2014 12:03:50 +1300 >Subject: [PATCH] Bug 12123 - [Alternative patch] HTML notices can break the > notice viewer > >Depending on the content of an html notice, it can cause the notice to >either not be collapsible, be uncollapsible, or to be permanently >collapsed. > >Also changes the layout of the table a bit to be a little more user friendly. > >Test Plan: >1) Set your CHECKOUT notice to the following ( with HTML Message checked ) : ><p>The following items have been checked out:</p> > >---- ><blockquote> <<biblio.title>> </blockquote> >---- > ><p>Thank you for visiting the <<branches.branchname>> of HMCPL.</p> >2) Check out some items to a patron >3) View the patrn's notices >4) Note the notice viewer is broken ( message is not collapsed, and > con't be collapsed ). >5) Apply this patch >6) Reload the page >7) Note the notice viewer is no longer broken >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt >index 31d40ba..f5ad8c6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt >@@ -41,13 +41,13 @@ > <h1>Sent notices for [% INCLUDE 'patron-title.inc' %]</h1> > > [% IF ( QUEUED_MESSAGES ) %] >- <table id="noticestable"> >+ <table id="noticestable" style="table-layout: fixed"> > <thead> > <tr> >- <th>Notice</th> >- <th>Type</th> >- <th>Status</th> >- <th>Time</th> >+ <th width="600px">Notice</th> >+ <th width="40px">Type</th> >+ <th width="40px">Status</th> >+ <th width="100px">Time</th> > </tr> > </thead> > <tbody> >@@ -55,9 +55,9 @@ > <tr> > <td> > <a class="notice-title" href="#">[% QUEUED_MESSAGE.subject %]</a> >- <p class="notice"> >+ <div class="notice"> > [% QUEUED_MESSAGE.content FILTER html_line_break %] >- </p> >+ </div> > </td> > <td> > [% IF ( QUEUED_MESSAGE.message_transport_type == 'email' ) %]email >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12123
:
27402
|
27403
|
33863
|
33876
|
33882
|
33885
|
33888
|
33950
|
33976
|
73650
|
73758
|
74113
|
74169