Bugzilla – Attachment 33928 Details for
Bug 13331
Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
fix for 13331 [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks
fix-for-13331-Bug-13331-Subfield-does-not-show-in-.patch (text/plain), 1.82 KB, created by
Mason James
on 2014-11-26 01:04:59 UTC
(
hide
)
Description:
fix for 13331 [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks
Filename:
MIME Type:
Creator:
Mason James
Created:
2014-11-26 01:04:59 UTC
Size:
1.82 KB
patch
obsolete
>From 91db840263765d60bbc8a6dddd412837b3c267c8 Mon Sep 17 00:00:00 2001 >From: Mason James <mtj@kohaaloha.com> >Date: Wed, 26 Nov 2014 13:51:45 +1300 >Subject: [PATCH] fix for 13331 [Bug 13331] Subfield does not show in > cataloging editor - if subfield is disabled in OPAC/enabled > in Staff, via frameworks >Content-Type: text/plain; charset="utf-8" > >to test... > >1/ attempt to add a new bib in the cataloguing editor, default framewok > - observe 245b subfield is visible in the editor, for tab 2 > >2/ uncheck the OPAC visibility for 245b, within the framework editor - then save > >3/ repeat step 1/ > - observe that the 245b subfield has disappeared from the cataloguing editor! > >4/ apply patch, > >5/ repeat step 1/ > - observe that the 245b subfield now displays correctly in the cataloguing editor > >note: this looks looks like a typo bug, that has been in koha for years >--- > cataloguing/addbiblio.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl >index 5b06706..645a30a 100755 >--- a/cataloguing/addbiblio.pl >+++ b/cataloguing/addbiblio.pl >@@ -653,8 +653,8 @@ sub build_tabs { > foreach my $subfield ( sort( keys %{ $tagslib->{$tag} } ) ) { > next if ( length $subfield != 1 ); > next >- if ( ( $tagslib->{$tag}->{$subfield}->{hidden} <= -5 ) >- or ( $tagslib->{$tag}->{$subfield}->{hidden} >= 4 ) ) >+ if ( ( $tagslib->{$tag}->{$subfield}->{hidden} <= -4 ) >+ or ( $tagslib->{$tag}->{$subfield}->{hidden} >= 5 ) ) > and not ( $subfield eq "9" and > exists($tagslib->{$tag}->{'a'}->{authtypecode}) and > defined($tagslib->{$tag}->{'a'}->{authtypecode}) and >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13331
:
33891
|
33892
|
33893
|
33928
|
34007
|
34151