Bugzilla – Attachment 33938 Details for
Bug 13215
letter.code is considered as a primary key
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13215: (follow-up) Fix notice edition
Bug-13215-follow-up-Fix-notice-edition.patch (text/plain), 1.37 KB, created by
Chris Cormack
on 2014-11-26 02:24:59 UTC
(
hide
)
Description:
Bug 13215: (follow-up) Fix notice edition
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2014-11-26 02:24:59 UTC
Size:
1.37 KB
patch
obsolete
>From 97508b9fc811b90c2533c34864a18da28c52d4b3 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Fri, 21 Nov 2014 16:13:41 +0100 >Subject: [PATCH] Bug 13215: (follow-up) Fix notice edition > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >--- > tools/letter.pl | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > >diff --git a/tools/letter.pl b/tools/letter.pl >index 4fcd8a8..ab4f78f 100755 >--- a/tools/letter.pl >+++ b/tools/letter.pl >@@ -254,12 +254,18 @@ sub add_validate { > my $title = shift @title; > my $content = shift @content; > my $letter = C4::Letters::getletter( $oldmodule, $code, $branchcode, $mtt); >+ >+ # getletter can return the default letter even if we pass a branchcode >+ # If we got the default one and we needed the specific one, we didn't get the one we needed! >+ if ( $letter and $branchcode ne $letter->{branchcode} ) { >+ $letter = undef; >+ } > unless ( $title and $content ) { > # Delete this mtt if no title or content given > delete_confirmed( $branchcode, $oldmodule, $code, $mtt ); > next; > } >- elsif ( $letter->{message_transport_type} eq $mtt ) { >+ elsif ( $letter and $letter->{message_transport_type} eq $mtt ) { > $dbh->do( > q{ > UPDATE letter >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13215
:
33316
|
33637
|
33772
|
33773
|
33788
|
33909
|
33930
|
33931
|
33932
|
33933
|
33934
|
33935
|
33936
|
33937
|
33938
|
33939
|
33971
|
33972
|
33973
|
33974
|
33975
|
33995