From 1786cc60bc6046e3cc03f2fb1c4775680c38d15d Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Wed, 3 Sep 2014 19:15:12 -0400 Subject: [PATCH] Bug 12868: Wrong variable used for borrower number When only the card number is passed to GetMemberDetail, the value of $borrowernumber is undefined. Even after finding the correct borrower and providing a nice hash ($borrower), the GetMemberAccountRecords is called with the wrong borrower number, even though it is in the hash ($borrower). This was fixed by changing $borrowernumber to $borrower->{borrowernumber}, so that the hash's value will always be used, since it is correct regardless of whether borrowernumber or cardnumber were used to find the borrower. TEST PLAN --------- 1) Apply both patches 2) prove -v t/db_dependent/Member.t -- This time the previously failing test will pass. 3) run koha QA test tools. Signed-off-by: Jonathan Druart --- C4/Members.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Members.pm b/C4/Members.pm index d88ea45..375797d 100644 --- a/C4/Members.pm +++ b/C4/Members.pm @@ -361,7 +361,7 @@ sub GetMemberDetails { } my $borrower = $sth->fetchrow_hashref; return unless $borrower; - my ($amount) = GetMemberAccountRecords( $borrowernumber); + my ($amount) = GetMemberAccountRecords($borrower->{borrowernumber}); $borrower->{'amountoutstanding'} = $amount; # FIXME - patronflags calls GetMemberAccountRecords... just have patronflags return $amount my $flags = patronflags( $borrower); -- 2.1.0