From 29914510a42e62a8807eac5e06b69421b26a7075 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 10 Mar 2014 11:58:33 +0100 Subject: [PATCH] Bug 7677: FIX QA issues FAIL C4/Serials.pm FAIL forbidden patterns forbidden pattern: trailing space char (line 1501) forbidden pattern: trailing space char (line 921) FAIL serials/serials-edit.pl FAIL valid "my" variable $dbh masks earlier declaration in same scope --- C4/Serials.pm | 4 ++-- serials/serials-edit.pl | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/C4/Serials.pm b/C4/Serials.pm index 44d57b8..1432a41 100644 --- a/C4/Serials.pm +++ b/C4/Serials.pm @@ -920,7 +920,7 @@ sub GetPreviousSerialid { FROM serial WHERE subscriptionid = ? AND status = 2 - ORDER BY serialid DESC LIMIT $nth,1 + ORDER BY serialid DESC LIMIT $nth,1 "; my $sth = $dbh->prepare($strsth); $sth->execute($subscriptionid); @@ -1467,7 +1467,7 @@ $subscriptionid = &NewSubscription($auser,branchcode,$aqbooksellerid,$cost,$aqbu $lastvalue1,$innerloop1,$lastvalue2,$innerloop2,$lastvalue3,$innerloop3, $status, $notes, $letter, $firstacquidate, $irregularity, $numberpattern, $locale, $callnumber, $manualhistory, $internalnotes, $serialsadditems, - $staffdisplaycount, $opacdisplaycount, $graceperiod, $location, $enddate, + $staffdisplaycount, $opacdisplaycount, $graceperiod, $location, $enddate, $skip_serialseq, $itemtype, $previousitemtype); Create a new subscription with value given on input args. diff --git a/serials/serials-edit.pl b/serials/serials-edit.pl index 89c002e..0fbe442 100755 --- a/serials/serials-edit.pl +++ b/serials/serials-edit.pl @@ -90,7 +90,6 @@ if ( scalar(@subscriptionids) == 1 && index( $subscriptionids[0], q|,| ) > 0 ) { } my @errors; my @errseq; -my $dbh = C4::Context->dbh; # If user comes from subscription details unless (@serialids) { -- 2.1.0