Bugzilla – Attachment 3445 Details for
Bug 5838
Don't show sql statement on guided reports result page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Signed-off patch
bug_5838.patch (text/plain), 1.71 KB, created by
Jared Camins-Esakov
on 2011-03-27 17:31:53 UTC
(
hide
)
Description:
Signed-off patch
Filename:
MIME Type:
Creator:
Jared Camins-Esakov
Created:
2011-03-27 17:31:53 UTC
Size:
1.71 KB
patch
obsolete
>From c32015b5454ae37c2305d65b489d635cc6c17323 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Sun, 27 Mar 2011 19:06:08 +0200 >Subject: [PATCH] Bug 5838: Format sql outout on guided reports >Content-Type: text/plain; charset="utf-8" > >New suggestion: wrapping the sql output in <pre> with an unique id. > >- sql can be formatted to be better readable >- sql can be hidden using css and the unique id >- pagination is pushed to its own line and better visible > >Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com> >--- > .../en/modules/reports/guided_reports_start.tmpl | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tmpl >index 6933393..eb8d4fb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tmpl >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tmpl >@@ -499,8 +499,8 @@ NAME="name" -->"><!-- TMPL_VAR NAME="name"--></label></td><td> > <h1><!-- TMPL_VAR NAME="name" --></h1> > <!-- TMPL_IF NAME="notes" --><p><!-- TMPL_VAR NAME="notes" --></p><!-- /TMPL_IF --> > <!-- TMPL_IF NAME="unlimited_total" --><p>Total number of rows matching the (unlimited) query is <!-- TMPL_VAR NAME="unlimited_total" -->.</p><!-- /TMPL_IF --> >-<!-- TMPL_VAR name="sql" --> >-<!-- TMPL_VAR NAME='pagination_bar' DEFAULT="" --> >+<pre id="sql_output"><!-- TMPL_VAR name="sql" --></pre> >+<p><!-- TMPL_VAR NAME='pagination_bar' DEFAULT="" --></p> > <!-- TMPL_UNLESS name="errors" --> > <table> > <tr><!-- TMPL_LOOP NAME="header_row" --><th><!-- TMPL_VAR NAME="cell" --></th><!-- /TMPL_LOOP --></tr> >-- >1.7.2.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5838
:
3258
|
3442
|
3443
| 3445