From 87e865d4e1ceb7927708f21dc4a74a6acd9cb7ba Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Thu, 11 Dec 2014 09:47:01 -0500 Subject: [PATCH] [PASSED QA] Bug 13442 - Facet links broken when collection code limit is used MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Any search limits including a ccode will break the search facts. Test Plan: 1) Run an advanced search using a ccode limit 2) Try using any of the facet links of the left 3) Note they are broken 4) Apply this patch 5) Refresh the results 6) Note the facet links are no longer broken Note: I have not been able to reproduce this issue on my own test system, but have noted the problem on at least a dozen Koha servers. I could not reproduce the bug either, but I saw it on the Bywater Demo (comment #1). Applied patch and tested facets, no problems found, signing off Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer Can not reproduce the problem, but I can also not find a regression. --- C4/Search.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Search.pm b/C4/Search.pm index 1326f69..c7577b4 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -1705,7 +1705,7 @@ sub buildQuery { if ( $k !~ /mc-i(tem)?type/ ) { # in case the mc-ccode value has complicating chars like ()'s inside it we wrap in quotes $this_limit =~ tr/"//d; - $this_limit = $k.":\"".$v."\""; + $this_limit = $k.":'".$v."'"; } $group_OR_limits{$k} .= " or " if $group_OR_limits{$k}; -- 1.9.1