From b77645c438d0cbdb2537fcc1566e23bc10a9e390 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 10 Dec 2014 09:02:57 -0500 Subject: [PATCH] [PASSED QA] [PASSED QA] Bug 13341 - Hard-coded "Preview" text in OPAC openlibrary.js MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The OpenLibrary JavaScript includes an untranslated string, "Preview." This patch move the string to the template so that it can be translated. To test, apply the patch and test that the translator picks up the string: 1. From misc/translator run 'perl translate update [lang]' (e.g. de-DE) 2. Edit misc/translator/po/[lang]-opac-bootstrap.po and add a translation for the updated "Preview" string 3. Remove the "#, fuzzy" marker from that entry 4. From misc/translator run 'perl translate install [lang]' 5. Enable the [lang] translation for the OPAC in system preferences 6. Enable the OpenLibraryCovers system preference. 7. In the OPAC switch to the [lang] translation. 7. View the detail page for a title for which there is an OpenLibrary cover image. Below it you should see a preview link with the translated string you added in step 2. Works as expected. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer --- koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc | 1 + koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc index f4c35c2..0220d26 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc @@ -170,6 +170,7 @@ $.widget.bridge('uitooltip', $.ui.tooltip); [% END %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js b/koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js index 9142273..995cb6b 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js +++ b/koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js @@ -49,7 +49,7 @@ KOHA.OpenLibrary = { if (is_opacdetail) { img.src = book.cover.medium; $(this).empty().append(img); - $(this).append('
' + 'Preview
'); + $(this).append(''); } else { img.src = book.cover.medium; img.height = '110'; -- 1.9.1