@@ -, +, @@ earlier patch, on this patchset - $data{'userid'} = Generate_Userid($data{'borrowernumber'}, + $data{'userid'} = Generate_Userid( $data{'borrowernumber'}, + if ( $data{'userid'} eq '' || Check_Userid( $data{'userid'} ) ); --- C4/Members.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/C4/Members.pm +++ a/C4/Members.pm @@ -856,7 +856,7 @@ sub AddMember { # generate a proper login if none provided $data{'userid'} = Generate_Userid( $data{'borrowernumber'}, $data{'firstname'}, $data{'surname'} ) - if ( $data{'userid'} eq '' || Check_Userid( $data{'userid'} ) ); + if ( $data{'userid'} eq '' || !Check_Userid( $data{'userid'} ) ); # add expiration date if it isn't already there unless ( $data{'dateexpiry'} ) { --