From b9ec89e8a4c63e31c3b19f5f5ee04312011552ca Mon Sep 17 00:00:00 2001 From: Chris Cormack Date: Wed, 31 Dec 2014 10:20:59 +1300 Subject: [PATCH] Bug 13502 : Code introcduced in 1861 wrongly assumes a null userid is unique To test 1/ Create a borrower with '' as their userid, you may have to edit a row in the db to do this 2/ Run perl t/db_dependent/Circulation/CheckIfIssuedToPatron.t 3/ Notice some tests fail and you see DBD::mysql::st execute failed: Duplicate entry '' for key 'userid' at /home/chrisc/git/catalyst-koha/C4/SQLHelper.pm line 184. 4/ Apply the patch 5/ Run the tests again, notice they now pass --- C4/Members.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Members.pm b/C4/Members.pm index e1449df..91f4331 100644 --- a/C4/Members.pm +++ b/C4/Members.pm @@ -920,7 +920,7 @@ sub AddMember { sub Check_Userid { my ( $uid, $borrowernumber ) = @_; - return 1 unless ($uid); + return 0 unless ($uid); # userid is a unique column, we should assume NULL is not unique return 0 if ( $uid eq C4::Context->config('user') ); -- 2.1.4