From eaa37c98c0142acf8ebc7e0f16c9ce65197a86c8 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 31 Dec 2014 12:09:49 +0100 Subject: [PATCH] Bug 13502: Add tests to highlight the problem Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi --- t/db_dependent/Members.t | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Members.t b/t/db_dependent/Members.t index f79e3f8..8c42aff 100755 --- a/t/db_dependent/Members.t +++ b/t/db_dependent/Members.t @@ -17,7 +17,7 @@ use Modern::Perl; -use Test::More tests => 70; +use Test::More tests => 72; use Test::MockModule; use Data::Dumper; use C4::Context; @@ -304,6 +304,18 @@ $borrowernumber = AddMember( %data ); $borrower = GetMember( borrowernumber => $borrowernumber ); is( $borrower->{userid}, $data{userid}, 'AddMember should insert the given userid' ); +# Regression tests for BZ13502 +## Remove all entries with userid='' (should be only 1 max) +$dbh->do(q|DELETE FROM borrowers WHERE userid = ''|); +## And create a patron with a userid='' +$borrowernumber = AddMember( categorycode => 'S', branchcode => 'MPL' ); +$dbh->do(q|UPDATE borrowers SET userid = '' WHERE borrowernumber = ?|, undef, $borrowernumber); +# Create another patron and verify the userid has been generated +$borrowernumber = AddMember( categorycode => 'S', branchcode => 'MPL' ); +ok( $borrowernumber > 0, 'AddMember should have inserted the patron even if no userid is given' ); +$borrower = GetMember( borrowernumber => $borrowernumber ); +ok( $borrower->{userid}, 'A userid should have been generated correctly' ); + # Regression tests for BZ12226 is( Check_Userid( C4::Context->config('user'), '' ), 0, 'Check_Userid should return 0 for the DB user (Bug 12226)'); -- 1.9.1