From 241cf44bad6a4f6f723ccee09256fffaac380898 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@biblibre.com>
Date: Wed, 30 Apr 2014 10:30:34 +0200
Subject: [PATCH] [PASSED QA] Bug 11023: Don't use the biblioitems fields for the subtitution

It's dangerous to allow a change on the biblioitems fields with this
feature.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
---
 .../prog/en/modules/tools/toggle_new_status.tt     |    8 ++++----
 tools/toggle_new_status.pl                         |    3 ++-
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/toggle_new_status.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/toggle_new_status.tt
index 8a0d5ae..7791d6f 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/toggle_new_status.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/toggle_new_status.tt
@@ -155,7 +155,7 @@
                         <div class="block">
                           <select name="condition_field_[% id %]">
                             <option value="">Choose a field name</option>
-                            [% FOR field IN fields %]
+                            [% FOR field IN condition_fields %]
                               [% IF condition.field == field %]
                                 <option value="[% field %]" selected="selected">[% field %]</option>
                               [% ELSE %]
@@ -176,7 +176,7 @@
                         <div class="block">
                           <select name="substitution_field_[% id %]">
                             <option value="">Choose a field name</option>
-                            [% FOR field IN fields %]
+                            [% FOR field IN substitution_fields %]
                               [% IF substitution.field == field %]
                                 <option value="[% field %]" selected="selected">[% field %]</option>
                               [% ELSE %]
@@ -217,7 +217,7 @@
               <div class="block">
                 <select name="condition_field">
                   <option value="">Choose a field name</option>
-                  [% FOR field IN fields %]
+                  [% FOR field IN condition_fields %]
                     <option value="[% field %]">[% field %]</option>
                   [% END %]
                 </select>
@@ -232,7 +232,7 @@
               <div class="block">
                 <select name="substitution_field">
                   <option value="">Choose a field name</option>
-                  [% FOR field IN fields %]
+                  [% FOR field IN substitution_fields %]
                     <option value="[% field %]">[% field %]</option>
                   [% END %]
                 </select>
diff --git a/tools/toggle_new_status.pl b/tools/toggle_new_status.pl
index c7b88d4..a37ea1a 100755
--- a/tools/toggle_new_status.pl
+++ b/tools/toggle_new_status.pl
@@ -111,7 +111,8 @@ my @biblioitem_fields = map { "biblioitems.$_" } C4::Items::biblioitems_columns;
 $template->param(
     op => $op,
     messages => \@messages,
-    fields => [ @item_fields, @biblioitem_fields ],
+    condition_fields => [ @item_fields, @biblioitem_fields ],
+    substitution_fields => \@item_fields,
     rules => $rules,
 );
 
-- 
1.7.2.5