Bugzilla – Attachment 35041 Details for
Bug 13522
tools/viewlog.pl does not compile in older perls
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13522: Make it explicit that scalar containd a hash ref
PASSED-QA-Bug-13522-Make-it-explicit-that-scalar-c.patch (text/plain), 1.26 KB, created by
Kyle M Hall
on 2015-01-09 11:55:07 UTC
(
hide
)
Description:
[PASSED QA] Bug 13522: Make it explicit that scalar containd a hash ref
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2015-01-09 11:55:07 UTC
Size:
1.26 KB
patch
obsolete
>From 40d6897cb48a8be44f2fcb6c674b04c7b239690f Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Tue, 6 Jan 2015 11:40:46 +0000 >Subject: [PATCH] [PASSED QA] Bug 13522: Make it explicit that scalar containd a hash ref > >Prior to perl 5.12 keys can only operate on a hash. So although >$data[0] ( thats an abysmal variable name! ) will contain a hash ref >the perl compiler cannot deduce that from the context and gives >a syntax error. Add the hash sigil to make the context explicit and >the compiler can generate the correct code. > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > tools/viewlog.pl | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/tools/viewlog.pl b/tools/viewlog.pl >index 9f68a8a..e526c1f 100755 >--- a/tools/viewlog.pl >+++ b/tools/viewlog.pl >@@ -211,7 +211,7 @@ if ($do_it) { > > # First line with heading > # Exporting bd id seems useless >- my @headings = grep { $_ ne 'action_id' } sort keys $data[0]; >+ my @headings = grep { $_ ne 'action_id' } sort keys %{$data[0]}; > if ( $csv->combine(@headings) ) { > $content .= $csv->string() . "\n"; > } >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13522
:
34978
|
35034
| 35041