Bugzilla – Attachment 3519 Details for
Bug 5905
Biblibre, Partial fine payments
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Follow up patch
0002-Bug-5905-Follow-up-fixing-sql-to-use-placeholders.patch (text/plain), 2.30 KB, created by
Julian Maurice
on 2011-03-30 09:11:12 UTC
(
hide
)
Description:
Follow up patch
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2011-03-30 09:11:12 UTC
Size:
2.30 KB
patch
obsolete
>From ebe7bf93cff705f901393bba341be680a009cbc4 Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chrisc@catalyst.net.nz> >Date: Mon, 21 Mar 2011 11:21:49 +1300 >Subject: [PATCH 2/3] Bug 5905 : Follow up fixing sql to use placeholders > >--- > C4/Accounts.pm | 29 ++++++++++++++--------------- > 1 files changed, 14 insertions(+), 15 deletions(-) > >diff --git a/C4/Accounts.pm b/C4/Accounts.pm >index 584c3f7..cd29dd8 100644 >--- a/C4/Accounts.pm >+++ b/C4/Accounts.pm >@@ -182,22 +182,21 @@ sub makepayment { > $descriptionpayment="Part Payment for account nð".$accountno.",thanks - ".$user." : ".$data->{'description'}; > } > >- $dbh->do( >+ $sth = $dbh->prepare( > "UPDATE accountlines >- SET amountoutstanding = $newamountoutstanding >- WHERE id = $accountlineid >- " >- ); >- >- # create new line >- $dbh->do( " >- INSERT INTO accountlines >- (borrowernumber, accountno, date, time, amount, >- description, accounttype, amountoutstanding, >- note, meansofpayment, manager_id) >- VALUES ($borrowernumber, $nextaccntno, now(), CURRENT_TIME, $payment, >- '$descriptionpayment', 'Pay', 0, '$note', '$meansofpayment', '$manager_id') >+ SET amountoutstanding = ? >+ WHERE id = ? >+ "); >+ $sth->execute($newamountoutstanding,$accountlineid); >+ >+ $sth = $dbh->prepare( " >+ INSERT INTO accountlines >+ (borrowernumber, accountno, date, time, amount, >+ description, accounttype, amountoutstanding, note, >+ meansofpayment, manager_id) >+ VALUES (?,?, now(), CURRENT_TIME, ?, ?, 'Pay', 0, ?, ?, ?) > " ); >+ $sth->execute($borrowernumber, $nextaccntno, $payment, $descriptionpayment, $note, $meansofpayment, $manager_id); > > # FIXME - The second argument to &UpdateStats is supposed to be the > # branch code. >@@ -211,7 +210,7 @@ sub makepayment { > returnlost( $borrowernumber, $data->{'itemnumber'} ); > } > >- my $sth = $dbh->prepare("SELECT max(id) AS lastinsertid FROM accountlines"); >+ $sth = $dbh->prepare("SELECT max(id) AS lastinsertid FROM accountlines"); > $sth->execute(); > my $datalastinsertid = $sth->fetchrow_hashref; > $sth->finish; >-- >1.7.4.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5905
:
3369
|
3370
|
3409
|
3410
|
3411
|
3518
| 3519 |
3520
|
3773