From 1db6f0d332a54c0a93614c9f225cb400756197e4 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 8 May 2014 12:59:07 +0200 Subject: [PATCH] Bug 11944: Remove bad FIXME in guided_report Bug 11679 introduced a FIXME for this but it is wrong. The strings have to be encoded before generating the ods file. However, it is useless to decode column names. Signed-off-by: Jonathan Druart Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi --- reports/guided_reports.pl | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl index c357c70..9b09ac0 100755 --- a/reports/guided_reports.pl +++ b/reports/guided_reports.pl @@ -912,14 +912,7 @@ elsif ($phase eq 'Save Compound'){ # pass $sth, get back an array of names for the column headers sub header_cell_values { my $sth = shift or return (); - my @cols; - foreach my $c (@{$sth->{NAME}}) { - # TODO in Bug 11944 - #FIXME apparently DBI still needs a utf8 fix for this? - $c = Encode::decode('UTF-8', $c); - push @cols, $c; - } - return @cols; + return @{$sth->{NAME}}; } # pass $sth, get back a TMPL_LOOP-able set of names for the column headers -- 2.1.0