Bugzilla – Attachment 35263 Details for
Bug 13582
Able to view menu for Circulation History even when user does not have permission
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13582 - Able to view menu for Circulation History even when user does not have permission Added check for borrowers that stops the Circulation History link being shown. This could be done through the css but that function currently appears to be broke
Bug-13582---Able-to-view-menu-for-Circulation-Hist.patch (text/plain), 1.93 KB, created by
Thomas Wright
on 2015-01-14 22:07:56 UTC
(
hide
)
Description:
Bug 13582 - Able to view menu for Circulation History even when user does not have permission Added check for borrowers that stops the Circulation History link being shown. This could be done through the css but that function currently appears to be broke
Filename:
MIME Type:
Creator:
Thomas Wright
Created:
2015-01-14 22:07:56 UTC
Size:
1.93 KB
patch
obsolete
>From ce60fab0b6edb137e3e6d6c4d7f9135f132c6010 Mon Sep 17 00:00:00 2001 >From: Thomas <tomsStudy@gmail.com> >Date: Wed, 14 Jan 2015 22:03:40 +0000 >Subject: [PATCH] Bug 13582 - Able to view menu for Circulation History even > when user does not have permission Added check for > borrowers that stops the Circulation History link being > shown. This could be done through the css but that function > currently appears to be broken. > >Testing Plan: > >-Search for a patron with an account that does not have the 'borrowers' permission >*Circulation history should not be seen in the menu. > >-Change the accounts permissions so they have the 'borrowers' permission >*Circulation history should be present in the menu. >--- > koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >index 2fe0a68..d263cc8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >@@ -70,7 +70,8 @@ > [% IF ( finesview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[% borrowernumber %]">Fines</a></li> > [% END %] > [% IF ( RoutingSerials ) %][% IF ( routinglistview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/routing-lists.pl?borrowernumber=[% borrowernumber %]">Routing lists</a></li>[% END %] >- [% IF ( intranetreadinghistory ) %] >+ <!-- Added check for borrowers permission as this is needed to access Cirulation History --> >+ [% IF ( intranetreadinghistory && CAN_user_borrowers ) %] > [% IF ( readingrecordview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/readingrec.pl?borrowernumber=[% borrowernumber %]">Circulation history</a></li> > [% END %] > [% IF ( CAN_user_parameters ) %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13582
:
35263
|
35359
|
35382
|
35383