From 96209b981f22d127b4bc6ba8609f1e97b8f2e4ad Mon Sep 17 00:00:00 2001 From: Thomas <tomsStudy@gmail.com> Date: Wed, 14 Jan 2015 20:49:27 +0000 Subject: [PATCH] [SIGNED OFF] Bug 10943 - Impossible to manage fines without borrowers permission Added check for borrowers permission as that is also required when accessing fines. Test Plan: -Search for a patron from an account without the 'borrowers' permission and with the 'updatecharges' permission. *The fines tab should not be present. -Update the account's permissions to include the 'borrowers' permission *The fines tab should now be present. -Update the account's permissions so it has neither 'borrowers' or 'updatecharges' *The fines tab should not be present Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. --- koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc index 2fe0a68..9e0fdca 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc @@ -66,7 +66,8 @@ [% IF ( CAN_user_borrowers ) %] [% IF ( detailview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">Details</a></li> [% END %] - [% IF ( CAN_user_updatecharges ) %] + <!-- Added check for borrowers permission. Borrowers permission is also needed to access linked page --> + [% IF ( CAN_user_updatecharges && CAN_user_borrowers ) %] [% IF ( finesview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[% borrowernumber %]">Fines</a></li> [% END %] [% IF ( RoutingSerials ) %][% IF ( routinglistview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/routing-lists.pl?borrowernumber=[% borrowernumber %]">Routing lists</a></li>[% END %] -- 1.9.1