From f2383f6f34858c9dc313979a7897b24a306a00ab Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 9 Jan 2015 16:01:35 +0100 Subject: [PATCH] [SIGNED OFF] Bug 13544: Make it explicit that getauthtypes returns a hash ref Prior to perl 5.12 keys can only operate on a hash. Test plan: With perl 5.10, access to admin/auth_subfields_structure.pl. Without this patch, you get: Type of arg 1 to keys must be hash (not subroutine entry) at /home/koha/src/admin/auth_subfields_structure.pl line 102, near "getauthtypes)" Signed-off-by: Katrin Fischer Confirmed problem and tested patch on a sandbox, signed off locally. --- admin/auth_subfields_structure.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/admin/auth_subfields_structure.pl b/admin/auth_subfields_structure.pl index 02eef5d..1a2ec15 100755 --- a/admin/auth_subfields_structure.pl +++ b/admin/auth_subfields_structure.pl @@ -99,7 +99,7 @@ if ($op eq 'add_form') { push @$authorised_values, 'itemtypes'; # build thesaurus categories list - my @authtypes = (sort keys getauthtypes); + my @authtypes = (sort keys %{C4::Koha::getauthtypes()}); # build value_builder list my @value_builder=(''); -- 1.9.1