Bugzilla – Attachment 35576 Details for
Bug 13635
$record->title is called even if marc flavour is UNIMARC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13635: Remove another useless call
Bug-13635-Remove-another-useless-call.patch (text/plain), 1.01 KB, created by
Jonathan Druart
on 2015-01-28 12:10:26 UTC
(
hide
)
Description:
Bug 13635: Remove another useless call
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-01-28 12:10:26 UTC
Size:
1.01 KB
patch
obsolete
>From 83e76d4b92b48089c6d3021175a4ef97500be9ce Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 28 Jan 2015 13:08:41 +0100 >Subject: [PATCH] Bug 13635: Remove another useless call > >There is another call to the title method in additem.pl without any >check on the marc flavour. >But here the title variable sent to the template is redefined 3 lines >later. >So it can be simply removed. >--- > cataloguing/additem.pl | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl >index 9c7fb3f..d127179 100755 >--- a/cataloguing/additem.pl >+++ b/cataloguing/additem.pl >@@ -847,7 +847,6 @@ foreach my $tag ( keys %{$tagslib}){ > @loop_data = sort {$a->{subfield} cmp $b->{subfield} } @loop_data; > > # what's the next op ? it's what we are not in : an add if we're editing, otherwise, and edit. >-$template->param( title => $record->title() ) if ($record ne "-1"); > $template->param( > biblionumber => $biblionumber, > title => $oldrecord->{title}, >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13635
:
35575
|
35576
|
36502
|
36507
|
36575
|
36607