Bugzilla – Attachment 35714 Details for
Bug 9351
item type not recorded correctly in statistics for returns and some local use
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 9351 - item type not recorded correctly in statistics for returns and some local use - followup
SIGNED-OFF-Bug-9351---item-type-not-recorded-corre.patch (text/plain), 2.06 KB, created by
Nick Clemens
on 2015-02-06 22:23:38 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 9351 - item type not recorded correctly in statistics for returns and some local use - followup
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2015-02-06 22:23:38 UTC
Size:
2.06 KB
patch
obsolete
>From 3f47dc6f75ef5b3566c84adbfdb728a8716f75ed Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 28 Jan 2015 14:12:11 +0100 >Subject: [PATCH] [SIGNED OFF] Bug 9351 - item type not recorded correctly in > statistics for returns and some local use - followup > >This patch corrects previous for AddReturn() : >- $item->{'itype'} instead of $biblio->{'itype'} >- and my $biblio is not set so it is useless >- removes FIXME comment > >Also adds a TODO comment in CanBookBeIssued() : >- $item->{'itemtype'}=$item->{'itype'}, this line may be useless now > >Signed-off-by: Nick <nick@quecheelibrary.org> >--- > C4/Circulation.pm | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index a9cc0dd..411271f 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -702,7 +702,7 @@ sub CanBookBeIssued { > my $item = GetItem(GetItemnumberFromBarcode( $barcode )); > my $issue = GetItemIssue($item->{itemnumber}); > my $biblioitem = GetBiblioItemData($item->{biblioitemnumber}); >- $item->{'itemtype'}=$item->{'itype'}; >+ $item->{'itemtype'}=$item->{'itype'}; #TODO maybe useless > my $dbh = C4::Context->dbh; > > # MANDATORY CHECKS - unless item exists, nothing else matters >@@ -1745,7 +1745,6 @@ sub AddReturn { > $branch = C4::Context->userenv->{'branch'} unless $branch; # we trust userenv to be a safe fallback/default > my $messages; > my $borrower; >- my $biblio; > my $doreturn = 1; > my $validTransfert = 0; > my $stat_type = 'return'; >@@ -1983,12 +1982,11 @@ sub AddReturn { > } > > # Record the fact that this book was returned. >- # FIXME itemtype should record item level type, not bibliolevel type > UpdateStats({ > branch => $branch, > type => $stat_type, > itemnumber => $item->{'itemnumber'}, >- itemtype => $biblio->{'itype'}, >+ itemtype => $item->{'itype'}, > borrowernumber => $borrowernumber, > ccode => $item->{'ccode'}} > ); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9351
:
18545
|
18626
|
18627
|
18699
|
23692
|
34818
|
34819
|
34994
|
34995
|
35578
|
35712
|
35713
|
35714
|
39456
|
39457
|
39458