Bugzilla – Attachment 35729 Details for
Bug 13672
OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13672 - OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords
PASSED-QA-Bug-13672---OPAC-locks-up-browser-when-b.patch (text/plain), 1.94 KB, created by
Katrin Fischer
on 2015-02-08 15:59:23 UTC
(
hide
)
Description:
[PASSED QA] Bug 13672 - OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-02-08 15:59:23 UTC
Size:
1.94 KB
patch
obsolete
>From de1f45201aa3870e9032bb7936d4a3aca16dbdb7 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 5 Feb 2015 12:19:38 -0500 >Subject: [PATCH] [PASSED QA] Bug 13672 - OPAC locks up browser when browsing > items from series link with NoveList and OpacHighlightedWords > >It appears that an empty string is sneaking into the list of words >to highlight and that is causing the browser to freak out. > >Test Plan: >1) Enable NoveList >2) Enable OpacHighlightedItems >3) Search a title with a series (i.e. The Hunger Games) >4) Click into the record >5) Click on the series to search it >6) Click on a title in the search results >7) If Firefox doesn't crash, it gives the unresponsive script message >8) Apply this patch >9) Repeat steps 3-6 >10) Browser doesn't freak our > >Signed-off-by: Jason Robb <jrobb@sekls.org> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >could not confirm the problem, but small change and >highlighting terms on result list and couldn't find any >regressions in highlighting. >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 71b022b..3e5364f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -1434,6 +1434,7 @@ > > [% IF ( query_desc ) %][% IF ( OpacHighlightedWords ) %]var query_desc = "[% query_desc |replace("'", "\'") |replace('\n', '\\n') |replace('\r', '\\r') |html %]"; > q_array = query_desc.split(" "); >+ q_array = q_array.filter(function(n){ return n }); // Remove empty strings > highlightOn(); > $("#highlight_toggle_on" ).hide().click(function() {highlightOn() ; return false;}); > $("#highlight_toggle_off").show().click(function() {highlightOff(); return false;});[% END %][% END %] >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13672
:
35673
|
35675
| 35729