From d45d69632d5f36392b0e53f78b1f02c9aef5ab54 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 31 Mar 2011 12:44:17 -0400 Subject: [PATCH] [revised] Partial fix for Bug 4870, Damaged status does not prevent items from being selected for reserves Content-Type: text/plain; charset="utf-8" This patch changes the holds queue build process in order to require that items not be damaged in order to appear in the holds queue report. Revision adds a check for the AllowHoldsOnDamagedItems preference to determine whether a damaged item should be included in the holds queue report. --- misc/cronjobs/holds/build_holds_queue.pl | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/misc/cronjobs/holds/build_holds_queue.pl b/misc/cronjobs/holds/build_holds_queue.pl index b02ab60..f01153e 100755 --- a/misc/cronjobs/holds/build_holds_queue.pl +++ b/misc/cronjobs/holds/build_holds_queue.pl @@ -168,8 +168,9 @@ sub GetItemsAvailableToFillHoldRequestsForBib { $items_query .= "WHERE items.notforloan = 0 AND holdingbranch IS NOT NULL AND itemlost = 0 - AND wthdrawn = 0 - AND items.onloan IS NULL + AND wthdrawn = 0"; + $items_query .= " AND damaged = 0 " unless C4::Context->preference('AllowHoldsOnDamagedItems'); + $items_query .= " AND items.onloan IS NULL AND (itemtypes.notforloan IS NULL OR itemtypes.notforloan = 0) AND itemnumber NOT IN ( SELECT itemnumber -- 1.7.3