From 507d8e00461f65e8ef9248b4188a8ad79de8245d Mon Sep 17 00:00:00 2001 From: Julian Maurice Date: Mon, 18 Aug 2014 15:12:34 +0200 Subject: [PATCH 3/3] Bug 7290: Fix CanUserReceiveBasket tests CanUserReceiveBasket now verify the 'superlibrarian' status of user using $userenv->{flags} (IsSuperLibrarian) Signed-off-by: Paola Rossi --- t/Acquisition/CanUserReceiveBasket.t | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/t/Acquisition/CanUserReceiveBasket.t b/t/Acquisition/CanUserReceiveBasket.t index b0eb385..b7831e6 100644 --- a/t/Acquisition/CanUserReceiveBasket.t +++ b/t/Acquisition/CanUserReceiveBasket.t @@ -21,7 +21,10 @@ my $baskets = { } }; -my $userenv = {}; +my $userenv = { flags => 0 }; + +sub BeSuperLibrarian { $userenv->{flags} = 1; } +sub BeOrdinaryLibrarian { $userenv->{flags} = 0; } my $borrower = {}; @@ -38,7 +41,10 @@ my $order3 = { $userenv->{branch} = 'B1'; # User can receive any orders thanks to his permissions -ok( CanUserReceiveOrder($borrower, $order1, {superlibrarian => 1}) ); +BeSuperLibrarian(); +ok( CanUserReceiveOrder($borrower, $order1, {}) ); +BeOrdinaryLibrarian(); + ok( CanUserReceiveOrder($borrower, $order1, {acquisition => 1}) ); ok( CanUserReceiveOrder($borrower, $order1, {acquisition => { order_receive_all => 1 }}) ); @@ -56,7 +62,10 @@ ok( not CanUserReceiveOrder($borrower, $order3, {acquisition => { order_receive $userenv->{branch} = 'B2'; # User can receive any order thanks to his permissions -ok( CanUserReceiveOrder($borrower, $order1, {superlibrarian => 1}) ); +BeSuperLibrarian(); +ok( CanUserReceiveOrder($borrower, $order1, {}) ); +BeOrdinaryLibrarian(); + ok( CanUserReceiveOrder($borrower, $order1, {acquisition => 1}) ); ok( CanUserReceiveOrder($borrower, $order1, {acquisition => { order_receive_all => 1 }}) ); -- 1.7.10.4