From 6c524be53afec108b303cfaa5260d56e68f70f9e Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Sat, 21 Feb 2015 22:52:30 +0100 Subject: [PATCH] Bug 13746: On creating a new subscription, notes fields get confused For every subscription we have 4 notes fields in Koha, 2 are in the subscription itself and another 2 are in the subscription history. When creating a new subscription, the notes fields from the subscription get copied to the fields of the subscription history, leading to doubled up display of notes in the OPAC. To test: - Add a new subscription without patch - check manual history - Fill in both notes fields - Verify that the notes fields got also saved into the subscription history (easy from the Summary tab) - Apply patch - Add another subscription, like above - Verify now only the subscription notes fields are saved - Edit subscription and notes - verify all is ok - Edit subscription history (Planning tab) - verify all is ok Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart --- C4/Serials.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/C4/Serials.pm b/C4/Serials.pm index 49325cb..538d4bd 100644 --- a/C4/Serials.pm +++ b/C4/Serials.pm @@ -1432,11 +1432,11 @@ sub NewSubscription { # then create the 1st expected number $query = qq( INSERT INTO subscriptionhistory - (biblionumber, subscriptionid, histstartdate, opacnote, librariannote) - VALUES (?,?,?,?,?) + (biblionumber, subscriptionid, histstartdate) + VALUES (?,?,?) ); $sth = $dbh->prepare($query); - $sth->execute( $biblionumber, $subscriptionid, $startdate, $notes, $internalnotes ); + $sth->execute( $biblionumber, $subscriptionid, $startdate); # reread subscription to get a hash (for calculation of the 1st issue number) my $subscription = GetSubscription($subscriptionid); -- 2.1.0