From 5ba35b7807965f12ab75d0377bda31c91e249f2c Mon Sep 17 00:00:00 2001 From: Jonathan Druart <jonathan.druart@biblibre.com> Date: Tue, 17 Dec 2013 13:53:21 +0100 Subject: [PATCH] Bug 10855: Fix QA issues This patch fixes the following QA issues: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt FAIL forbidden patterns forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 12) Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> --- koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt | 4 +--- koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt | 4 ++-- .../intranet-tmpl/prog/en/modules/serials/subscription-detail.tt | 4 ++-- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt index 6e1a290..27fb232 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt @@ -9,9 +9,7 @@ </title> [% INCLUDE 'doc-head-close.inc' %] <link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" /> -<script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.dataTables.min.js"></script> -[% INCLUDE 'datatables-strings.inc' %] -<script type="text/javascript" src="[% themelang %]/js/datatables.js"></script> +[% INCLUDE "datatables.inc" %] <script type="text/javascript"> //<![CDATA[ $(document).ready(function(){ diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt index c3c9277..7f90e4c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt @@ -1,7 +1,7 @@ [% USE Branches %] [% INCLUDE 'doc-head-open.inc' %] -[% USE KohaAuthorisedValues %] +[% USE AuthorisedValues %] <title>Koha › Serials › Claims</title> [% INCLUDE 'doc-head-close.inc' %] [% INCLUDE 'calendar.inc' %] @@ -267,7 +267,7 @@ </td> [% FOR field IN additional_fields_for_subscription %] [% IF field.authorised_value_category %] - <td>[% KohaAuthorisedValues.GetByCode( field.authorised_value_category, missingissue.additional_fields.${field.name} ) %]</td> + <td>[% AuthorisedValues.GetByCode( field.authorised_value_category, missingissue.additional_fields.${field.name} ) %]</td> [% ELSE %] <td>[% missingissue.additional_fields.${field.name} %]</td> [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt index 9222779..3c224de 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt @@ -1,5 +1,5 @@ [% USE Branches %] -[% USE KohaAuthorisedValues %] +[% USE AuthorisedValues %] [% INCLUDE 'doc-head-open.inc' %] <title>Koha › Serials › Details for subscription #[% subscriptionid %]</title> [% INCLUDE 'doc-head-close.inc' %] @@ -135,7 +135,7 @@ $(document).ready(function() { <li> <span class="label">[% field.name %]:</span> [% IF field.authorised_value_category %] - [% KohaAuthorisedValues.GetByCode( field.authorised_value_category, additional_fields.${field.name} ) %] + [% AuthorisedValues.GetByCode( field.authorised_value_category, additional_fields.${field.name} ) %] [% ELSE %] [% additional_fields.${field.name} %] [% END %] -- 1.7.10.4