Bugzilla – Attachment 370 Details for
Bug 1807
search () give odd results with Zebra and ICU
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch to fix searching on ()
0049-Bug-1807-Commenting-out-flawed-nested-queries-implem.patch (text/plain), 1.47 KB, created by
Chris Cormack
on 2009-12-12 08:17:00 UTC
(
hide
)
Description:
Patch to fix searching on ()
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2009-12-12 08:17:00 UTC
Size:
1.47 KB
patch
obsolete
>From b801ca24a32cbaf637002aececf1eebad5b3cdd6 Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chris@bigballofwax.co.nz> >Date: Sat, 12 Dec 2009 21:13:40 +1300 >Subject: [PATCH] Bug 1807 - Commenting out flawed nested queries implementation, now users can search using () > >--- > C4/Search.pm | 16 +++++++++------- > 1 files changed, 9 insertions(+), 7 deletions(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index 2fe57ed..bec44d2 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -852,13 +852,15 @@ sub buildQuery { > > # pass nested queries directly > # FIXME: need better handling of some of these variables in this case >- if ( $query =~ /(\(|\))/ ) { >- return ( >- undef, $query, $simple_query, $query_cgi, >- $query, $limit, $limit_cgi, $limit_desc, >- $stopwords_removed, 'ccl' >- ); >- } >+ # Nested queries aren't handled well and this implementation is flawed and causes users to be >+ # unable to search for anything containing () commenting out, will be rewritten for 3.4.0 >+# if ( $query =~ /(\(|\))/ ) { >+# return ( >+# undef, $query, $simple_query, $query_cgi, >+# $query, $limit, $limit_cgi, $limit_desc, >+# $stopwords_removed, 'ccl' >+# ); >+# } > > # Form-based queries are non-nested and fixed depth, so we can easily modify the incoming > # query operands and indexes and add stemming, truncation, field weighting, etc. >-- >1.6.3.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 1807
:
370
|
371
|
35612
|
35646