From cc721f9c41ad0c7968681663d321dab8f60084a8 Mon Sep 17 00:00:00 2001 From: Thomas Date: Wed, 14 Jan 2015 20:20:36 +0000 Subject: [PATCH] [PASSED QA] Bug 13531: QA follow up A minor QA comment. ::: misc/migration_tools/bulkmarcimport.pl @@ +271,5 @@ > my ( $error, $results, $totalhits ) = C4::Search::SimpleSearch( $query, 0, 3, [$server] ); > + # changed to warn so able to continue with one broken record > + if ( defined $error ) { > + warn "unable to search the database for duplicates : $error"; > + next; For consistency with the rest of the script, should this perhaps be: next RECORD; Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall --- misc/migration_tools/bulkmarcimport.pl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl index 0b0b27e..8838303 100755 --- a/misc/migration_tools/bulkmarcimport.pl +++ b/misc/migration_tools/bulkmarcimport.pl @@ -272,7 +272,7 @@ RECORD: while ( ) { # changed to warn so able to continue with one broken record if ( defined $error ) { warn "unable to search the database for duplicates : $error"; - next; + next RECORD; } $debug && warn "$query $server : $totalhits"; if ( $results && scalar(@$results) == 1 ) { -- 1.7.2.5