From abdb224e3edf760929a083a8481251fcef0d1d7a Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Sun, 22 Mar 2015 22:07:32 +0100 Subject: [PATCH] [Signed-off] Bug 13890 - Switch from full serials permission to 'routing' permission for reordering routing lists MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit For changing the sequence of patrons on a routing list by changing one of the numbers via the pull downs, full serial permission is needed: To test: - Give your patron full serial permissions - Create a subscription and a routing list for it - Change the sequence on the routing list using the pull downs - Verify this works - Remove any of the serial sub permissions (claim serials or similar) - Verify changing the sequence now results in a permission error - Apply patch - Verify that the permission error is gone now - Remove the routing permission - Verify the permission error is back (but this seems to make sense) In general more fixes would be required to make all routing related features depend on the routing permission, but I think this fixes the bug making it depend on the correct permission. Followed test plan. Works as expected. Signed-off-by: Marc Véron --- serials/reorder_members.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/serials/reorder_members.pl b/serials/reorder_members.pl index ba19b8c..9ff633c 100755 --- a/serials/reorder_members.pl +++ b/serials/reorder_members.pl @@ -29,7 +29,7 @@ my $subscriptionid = $query->param('subscriptionid'); my $routingid = $query->param('routingid'); my $rank = $query->param('rank'); -checkauth( $query, 0, { serials => 1 }, 'intranet' ); +checkauth( $query, 0, { serials => 'routing' }, 'intranet' ); reorder_members( $subscriptionid, $routingid, $rank ); -- 1.7.10.4