From d4bb83d12e03725add5c6ba4531631401d54b195 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Tue, 15 Jul 2014 10:59:03 -0400 Subject: [PATCH] Bug 6427 - Update existing intranet scripts Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey --- circ/add_message.pl | 8 +--- circ/branchoverdues.pl | 3 +- circ/circulation.pl | 4 +- circ/del_message.pl | 8 +--- .../prog/en/includes/browser-strings.inc | 33 +++++++++++ .../intranet-tmpl/prog/en/includes/circ-menu.inc | 2 +- .../intranet-tmpl/prog/en/includes/circ-menu.tt | 2 +- .../intranet-tmpl/prog/en/includes/datatables.inc | 1 + .../prog/en/includes/members-menu.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/js/datatables.js | 24 ++++++++ .../prog/en/modules/circ/circulation-home.tt | 1 - .../prog/en/modules/circ/circulation.tt | 7 ++- .../intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- .../prog/en/modules/help/reports/guided_reports.tt | 18 ------ .../prog/en/modules/members/moremember-print.tt | 57 +++++++++++++------ .../prog/en/modules/reports/reports-home.tt | 1 - members/moremember.pl | 25 +++++---- members/summary-print.pl | 21 ++----- offline_circ/enqueue_koc.pl | 1 - offline_circ/process_koc.pl | 12 +++- 20 files changed, 137 insertions(+), 95 deletions(-) diff --git a/circ/add_message.pl b/circ/add_message.pl index 3506c9b..67197be 100755 --- a/circ/add_message.pl +++ b/circ/add_message.pl @@ -17,8 +17,7 @@ # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); @@ -26,11 +25,6 @@ use C4::Context; use C4::Auth; use C4::Output; use C4::Members; -use C4::Accounts; -use C4::Stats; -use C4::Koha; -use C4::Overdues; -use C4::Branch; # GetBranches my $input = new CGI; diff --git a/circ/branchoverdues.pl b/circ/branchoverdues.pl index 3698114..9c63ab0 100755 --- a/circ/branchoverdues.pl +++ b/circ/branchoverdues.pl @@ -49,9 +49,8 @@ use Data::Dumper; level 3 : only methode is possible : - Considered Lost the documents displayed on this interface, are checked on three points - - 1) the document must be on accountlines (Type 'FU') + - 1) the document must be overdue with fines - 2) item issues is not returned - - 3) this item as not been already notify FIXME: who is the author? FIXME: No privisions (i.e. "actions") for handling notices are implemented. diff --git a/circ/circulation.pl b/circ/circulation.pl index 22c5e24..8d6d20f 100755 --- a/circ/circulation.pl +++ b/circ/circulation.pl @@ -512,8 +512,6 @@ foreach my $flag ( sort keys %$flags ) { my $amountold = $borrower->{flags}->{'CHARGES'}->{'message'} || 0; $amountold =~ s/^.*\$//; # remove upto the $, if any -my ( $total, $accts, $numaccts) = GetMemberAccountRecords( $borrowernumber ); - if ( $borrowernumber && $borrower->{'category_type'} eq 'C') { my ( $catcodes, $labels ) = GetborCatFromCatType( 'A', 'WHERE category_type = ?' ); my $cnt = scalar(@$catcodes); @@ -590,7 +588,7 @@ $template->param( duedatespec => $duedatespec, message => $message, selectborrower => $selectborrower, - totaldue => sprintf('%.2f', $total), + totaldue => sprintf('%.2f', $borrower->{account_balance}), inprocess => $inprocess, is_child => ($borrowernumber && $borrower->{'category_type'} eq 'C'), circview => 1, diff --git a/circ/del_message.pl b/circ/del_message.pl index c04ff57..67d381c 100755 --- a/circ/del_message.pl +++ b/circ/del_message.pl @@ -17,8 +17,7 @@ # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); @@ -26,11 +25,6 @@ use C4::Context; use C4::Auth; use C4::Output; use C4::Members; -use C4::Accounts; -use C4::Stats; -use C4::Koha; -use C4::Overdues; -use C4::Branch; # GetBranches my $input = new CGI; diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/browser-strings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/browser-strings.inc index 3dda230..01a06a9 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/browser-strings.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/browser-strings.inc @@ -1,7 +1,40 @@ +[% USE AuthorisedValues %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc index 49a29ccb..397026e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc @@ -67,7 +67,7 @@ [% IF ( detailview ) %]
  • [% ELSE %]
  • [% END %]Details
  • [% END %] [% IF ( CAN_user_updatecharges ) %] - [% IF ( finesview ) %]
  • [% ELSE %]
  • [% END %]Fines
  • + [% IF ( accounts_view ) %]
  • [% ELSE %]
  • [% END %]Fines
  • [% END %] [% IF ( RoutingSerials ) %][% IF ( routinglistview ) %]
  • [% ELSE %]
  • [% END %]Routing lists
  • [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.tt b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.tt index 2a1da6b..fa0d138 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.tt @@ -70,7 +70,7 @@ in the global namespace %] [% IF ( detailview ) %]
  • [% ELSE %]
  • [% END %]Details
  • [% END %] [% IF ( CAN_user_updatecharges ) %] - [% IF ( finesview ) %]
  • [% ELSE %]
  • [% END %]Fines
  • + [% IF ( accounts_view ) %]
  • [% ELSE %]
  • [% END %]Fines
  • [% END %] [% IF ( RoutingSerials ) %][% IF ( routinglistview ) %]
  • [% ELSE %]
  • [% END %]Routing lists
  • [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc index 4381b01..77e1419 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc @@ -1,5 +1,6 @@ [% INCLUDE 'format_price.inc' %] +