From aed9e4ac4c7d7cd21ba11916e7c3044be2a0a52b Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Thu, 2 Apr 2015 11:15:14 -0400 Subject: [PATCH] Bug 13947: Correct call to GetBiblio to receive correct return value When you attempt to edit the manual history for a subscription, the title is blank. This is a result of an incorrect use of the GetBiblio function. TEST PLAN --------- 1) Log in to staff client 2) Serials 3) Search for an existing serial with manual history checked. -- creating one as needed is left as an exercise to the reader. 4) Click on the title of the serial for the details page. 5) Go to the Planning tab and click 'Edit History' -- Heading will be 'Subscription history for' without a title. 6) Apply patch 7) Refresh page. -- Heading will include the title correctly. 8) run koha qa test tools --- serials/subscription-history.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/serials/subscription-history.pl b/serials/subscription-history.pl index 9310b5d..267afcb 100755 --- a/serials/subscription-history.pl +++ b/serials/subscription-history.pl @@ -71,7 +71,7 @@ if($op && $op eq 'mod') { exit; } else { my $history = GetSubscriptionHistoryFromSubscriptionId($subscriptionid); - my (undef, $biblio) = GetBiblio($history->{'biblionumber'}); + my $biblio = GetBiblio($history->{'biblionumber'}); $template->param( subscriptionid => $subscriptionid, -- 1.9.1