From 15d3cbe899bda399f806aaa74b2eae032d77cc45 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 31 Mar 2015 16:32:33 +0200 Subject: [PATCH] [PASSED QA] Bug 8246: Allow deleting record if no more items The "Delete records if no items remain" was only available if the batch did not contain "too many" items (see MaxItemsForBatch). This limitation does not make any sense. Test plan: 1/ Set MaxItemsForBatch=10 2/ Use the batch item deletion to delete 10+ items 3/ Confirm the checkbox "Delete records if no items remain" is displayed 4/ Check it 5/ Launch the job 6/ Run koha qa test tools Verify that the records without items have been deleted also. NOTE: My test db only had two biblios with items, so I set MaxItemsForBatch=1. Before patch, checkbox did not display. After patch, checkbox did display. This patch merely moves one line out of the IF/ELSE/END block, and reindents for more readability. Though, there is a missing

if you want to get picky. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall --- .../prog/en/modules/tools/batchMod-del.tt | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt index 71cc9af..92d3137 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt @@ -135,9 +135,12 @@ for( x=0; xJob progress:

0%
- [% IF ( too_many_items ) %][% ELSE %] -

- [% END %] + + [% IF too_many_items %] + + [% ELSE %] + + [% END %] Cancel -- 1.7.2.5