Bugzilla – Attachment 37455 Details for
Bug 8246
can't delete bibs in big batch delete
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 8246: Allow deleting record if no more items
PASSED-QA-Bug-8246-Allow-deleting-record-if-no-mor.patch (text/plain), 2.77 KB, created by
Kyle M Hall
on 2015-04-03 13:09:41 UTC
(
hide
)
Description:
[PASSED QA] Bug 8246: Allow deleting record if no more items
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2015-04-03 13:09:41 UTC
Size:
2.77 KB
patch
obsolete
>From 15d3cbe899bda399f806aaa74b2eae032d77cc45 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Tue, 31 Mar 2015 16:32:33 +0200 >Subject: [PATCH] [PASSED QA] Bug 8246: Allow deleting record if no more items > >The "Delete records if no items remain" was only available if the batch >did not contain "too many" items (see MaxItemsForBatch). >This limitation does not make any sense. > >Test plan: >1/ Set MaxItemsForBatch=10 >2/ Use the batch item deletion to delete 10+ items >3/ Confirm the checkbox "Delete records if no items remain" is displayed >4/ Check it >5/ Launch the job >6/ Run koha qa test tools > >Verify that the records without items have been deleted also. > >NOTE: My test db only had two biblios with items, so I set > MaxItemsForBatch=1. > Before patch, checkbox did not display. > After patch, checkbox did display. > This patch merely moves one line out of the IF/ELSE/END > block, and reindents for more readability. Though, there > is a missing <p> if you want to get picky. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../prog/en/modules/tools/batchMod-del.tt | 9 ++++++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt >index 71cc9af..92d3137 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt >@@ -135,9 +135,12 @@ for( x=0; x<allColumns.length; x++ ){ > <div id="jobstatus">Job progress: <div id="jobprogress"></div> <span id="jobprogresspercent">0</span>%</div> > <div id="jobfailed"></div> > </div> >- [% IF ( too_many_items ) %]<input type="submit" name="mainformsubmit" value="Delete ALL submitted items" onclick="return submitBackgroundJob(this.form);" />[% ELSE %] >- <input type="checkbox" name="del_records" id="del_records" /> <label for="del_records">Delete records if no items remain.</label><p> >- <input type="submit" name="mainformsubmit" value="Delete selected items" onclick="return submitBackgroundJob(this.form);" />[% END %] >+ <input type="checkbox" name="del_records" id="del_records" /> <label for="del_records">Delete records if no items remain.</label> >+ [% IF too_many_items %] >+ <input type="submit" name="mainformsubmit" value="Delete ALL submitted items" onclick="return submitBackgroundJob(this.form);" /> >+ [% ELSE %] >+ <input type="submit" name="mainformsubmit" value="Delete selected items" onclick="return submitBackgroundJob(this.form);" /> >+ [% END %] > > <a href="/cgi-bin/koha/tools/batchMod.pl?del=1" class="cancel">Cancel</a> > </fieldset> >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8246
:
37408
|
37441
| 37455