Bugzilla – Attachment 38118 Details for
Bug 8688
Add a recall button to the biblio record details page.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8688: Cleaned up pointless parameter passing
Bug-8688-Cleaned-up-pointless-parameter-passing.patch (text/plain), 1.94 KB, created by
Mark Tompsett
on 2015-04-18 19:38:18 UTC
(
hide
)
Description:
Bug 8688: Cleaned up pointless parameter passing
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2015-04-18 19:38:18 UTC
Size:
1.94 KB
patch
obsolete
>From e3485ff460e49341d1a5d0a8f10550fcfa732831 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Sat, 18 Apr 2015 15:34:09 -0400 >Subject: [PATCH] Bug 8688: Cleaned up pointless parameter passing > >It does not make sense to $template->param( 'foo' => 'bar' ); >when in the template file we can Koha.Preference('foo') in order >to get 'bar'. >--- > catalogue/detail.pl | 1 - > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > >diff --git a/catalogue/detail.pl b/catalogue/detail.pl >index 147fb6d..c84188e 100755 >--- a/catalogue/detail.pl >+++ b/catalogue/detail.pl >@@ -91,7 +91,6 @@ if (C4::Context->preference("XSLTDetailsDisplay") ) { > } > > $template->param( 'SpineLabelShowPrintOnBibDetails' => C4::Context->preference("SpineLabelShowPrintOnBibDetails") ); >-$template->param( 'ShowRecallButton' => C4::Context->preference("ShowRecallButton") ); > $template->param( ocoins => GetCOinSBiblio($record) ); > > # some useful variables for enhanced content; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index b7d33b9..af7cfb5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -685,7 +685,7 @@ function verify_images() { > </a> > [% END %] > : due [% item.datedue %] >- [% IF ( ShowRecallButton ) %] >+ [% IF ( Koha.Preference('ShowRecallButton') ) %] > <input type="button" id="recall_[% item.itemnumber %]" name="recall_[% item.itemnumber %]" value="Recall" onclick="recall_item([% item.itemnumber %]);" /> > [% END %] > </span> >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8688
:
11827
|
11828
|
11913
|
11914
|
11915
|
11916
|
17740
|
36741
|
38111
|
38118
|
38119
|
39169
|
39170
|
39171
|
39172
|
39173
|
46155
|
46158