From fba332e7382d925599689e57d6283c8a60266187 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc=20V=C3=A9ron?= Date: Tue, 21 Apr 2015 17:19:06 +0200 Subject: [PATCH] [Follow-up] Provide parameter $infos in cronlogaction() (Alternative for patch Bug 13889: Log with parameters) To test: - Apply patches interactive and skip following patch: Bug 13889: Log with parameters - Tweak a cron job in order to call cronlogaction twice, one with a param at the beginning of the cron ob, e.g. cronlogaction("This is my message") and one without param. - Run this cron job. Result: You should have two entries in the log, one with and one without additional information after the path and name of the calling script. --- C4/Log.pm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/C4/Log.pm b/C4/Log.pm index b6f5163..6871add 100644 --- a/C4/Log.pm +++ b/C4/Log.pm @@ -83,15 +83,18 @@ sub logaction { =item cronlogaction - &cronlogaction(); + &cronlogaction($infos); Convenience routine to add a record into action_logs table from a cron job. +Logs the path and name of the calling script plus the information privided by param $infos. =cut #' sub cronlogaction { - logaction( 'CRONJOBS', 'Run', 0, (caller(0))[1] ) if C4::Context->preference('CronjobLog'); + my ($infos)=@_; + my $loginfo = (caller(0))[1] . ' ' . $infos; + logaction( 'CRONJOBS', 'Run', 0, $loginfo ) if C4::Context->preference('CronjobLog'); } -- 1.7.10.4