Bugzilla – Attachment 38324 Details for
Bug 10976
the assistant for reports uses the wrong value for the list of item types
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10976: Fix typo itemtype vs itemtypes
Bug-10976-Fix-typo-itemtype-vs-itemtypes.patch (text/plain), 1.68 KB, created by
Jonathan Druart
on 2015-04-22 11:28:18 UTC
(
hide
)
Description:
Bug 10976: Fix typo itemtype vs itemtypes
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-04-22 11:28:18 UTC
Size:
1.68 KB
patch
obsolete
>From f4cfb43b03cdb7e6cc4d3e3c395d5dfa0baf31d5 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 22 Apr 2015 13:22:58 +0200 >Subject: [PATCH] Bug 10976: Fix typo itemtype vs itemtypes > >When creating a new report, the limit step let you choose >itype|itemtype. >But it should be itype|itemtypes. >If you try to create a guided report and you choose this option as a >limit, you will get a warning on saving it: > Errors found when processing parameters for report: > itype: The authorized value category (itemtype) you selected does not exist. > >Looking at the code: reports/guided_reports.pl l.657 > elsif ( $authorised_value eq "itemtypes" ) { > >Test plan: >0/ Don't apply the patch >1/ Create a guided report, select Koha itemtype as a limit(step 4) >2/ Confirm you get the error when saving >3/ Apply the patch and repeat step 1 >4/ There is no error and the report should work correctly >--- > C4/Reports/Guided.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm >index 133b1fd..1e4edf2 100644 >--- a/C4/Reports/Guided.pm >+++ b/C4/Reports/Guided.pm >@@ -383,7 +383,7 @@ sub get_criteria { > my $list; > $list='branches' if $column eq 'branchcode' or $column eq 'holdingbranch' or $column eq 'homebranch'; > $list='categorycode' if $column eq 'categorycode'; >- $list='itemtype' if $column eq 'itype'; >+ $list='itemtypes' if $column eq 'itype'; > $list='ccode' if $column eq 'ccode'; > # TODO : improve to let the librarian choose the description at runtime > push @values, { availablevalues => "<<$column".($list?"|$list":'').">>" }; >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10976
:
38324
|
38657
|
38786