Bugzilla – Attachment 38355 Details for
Bug 13419
Add filters and server-side processing to the shelves list view
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13419: (QA followup) remove useless warnings
Bug-13419-QA-followup-remove-useless-warnings.patch (text/plain), 1.10 KB, created by
Tomás Cohen Arazi
on 2015-04-22 18:11:33 UTC
(
hide
)
Description:
Bug 13419: (QA followup) remove useless warnings
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2015-04-22 18:11:33 UTC
Size:
1.10 KB
patch
obsolete
>From 88eb0323d7bde5bc91b7c58bce2848fb502eb076 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Wed, 22 Apr 2015 14:58:05 -0300 >Subject: [PATCH] Bug 13419: (QA followup) remove useless warnings > >Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> >--- > C4/Auth.pm | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index f5e3316..0e1b03f 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -1949,11 +1949,13 @@ sub haspermission { > if ( $subperm eq '*' ) { > return 0 unless ( $flags->{$module} == 1 or ref( $flags->{$module} ) ); > } else { >- return 0 unless ( $flags->{$module} == 1 or >+ return 0 unless ( >+ ( defined $flags->{$module} and >+ $flags->{$module} == 1 ) >+ or > ( ref( $flags->{$module} ) and > exists $flags->{$module}->{$subperm} and >- $flags->{$module}->{$subperm} == 1 >- ) >+ $flags->{$module}->{$subperm} == 1 ) > ); > } > } >-- >2.3.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13419
:
34241
|
34242
|
34243
|
34504
|
34514
|
34515
|
34516
|
34517
|
34518
|
34577
|
34578
|
34579
|
34580
|
38188
|
38189
|
38190
|
38191
|
38193
|
38194
|
38195
|
38196
|
38347
| 38355