Bugzilla – Attachment 38462 Details for
Bug 11464
Saving preferences - Nothing to Save
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed-off] Bug 11464: Prevent wrong "nothing to save" message on saving syspref
Signed-off-Bug-11464-Prevent-wrong-nothing-to-save.patch (text/plain), 2.07 KB, created by
Marc Véron
on 2015-04-23 19:45:13 UTC
(
hide
)
Description:
[Signed-off] Bug 11464: Prevent wrong "nothing to save" message on saving syspref
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2015-04-23 19:45:13 UTC
Size:
2.07 KB
patch
obsolete
>From 3392d07d9b109a1a06198afa18da62513e7292d3 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Thu, 23 Apr 2015 16:57:31 +0200 >Subject: [PATCH] [Signed-off] Bug 11464: Prevent wrong "nothing to save" > message on saving syspref >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Sometime you get the "Nothing to save" message when clicking on the "save >all preferences" button, even if something has changed. > >On irritating behavior is the middle click: if you use the middle click >to paste some text in the input, the "keyup" event won't be trigger. >This patch replaces the "keyup" event with the "change", which works >as we want here. > >The issues: >1/ Search for "wanted" (admin/preferences.pl?op=search&searchfield=wanted) >Empty the input, click save >Type something and remove it >You are able to save, but nothing has changed >2/ Put something in your selection buffer and use the middle click to >paste it in the input. >No change detected. > >Test plan: >Confirm the issues are fixed and you don't find any regression >Note that now the "(modified)" string is displayed when the input loses >the focus. > >Followed test plan. Works as expected. >Signed-off-by: Marc Véron <veron@veron.ch> >--- > koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js b/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js >index 9800f47..04135ef 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js >+++ b/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js >@@ -63,7 +63,7 @@ $( document ).ready( function () { > } > > $( '.prefs-tab' ) >- .find( 'input.preference, textarea.preference' ).keyup( function () { >+ .find( 'input.preference, textarea.preference' ).on('change', function () { > if ( this.defaultValue === undefined || this.value != this.defaultValue ) mark_modified.call( this ); > } ).end() > .find( 'select.preference' ).change( mark_modified ); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11464
:
38426
|
38462
|
38616