From c73cbd6a43d93a447fc8b9b691ea3fc68b730a47 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 23 Apr 2015 16:57:31 +0200 Subject: [PATCH] [PASSED QA] Bug 11464: Prevent wrong "nothing to save" message on saving syspref MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sometime you get the "Nothing to save" message when clicking on the "save all preferences" button, even if something has changed. On irritating behavior is the middle click: if you use the middle click to paste some text in the input, the "keyup" event won't be trigger. This patch replaces the "keyup" event with the "change", which works as we want here. The issues: 1/ Search for "wanted" (admin/preferences.pl?op=search&searchfield=wanted) Empty the input, click save Type something and remove it You are able to save, but nothing has changed 2/ Put something in your selection buffer and use the middle click to paste it in the input. No change detected. Test plan: Confirm the issues are fixed and you don't find any regression Note that now the "(modified)" string is displayed when the input loses the focus. Followed test plan. Works as expected. Signed-off-by: Marc VĂ©ron Signed-off-by: Katrin Fischer --- koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js b/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js index 9800f47..04135ef 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js +++ b/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js @@ -63,7 +63,7 @@ $( document ).ready( function () { } $( '.prefs-tab' ) - .find( 'input.preference, textarea.preference' ).keyup( function () { + .find( 'input.preference, textarea.preference' ).on('change', function () { if ( this.defaultValue === undefined || this.value != this.defaultValue ) mark_modified.call( this ); } ).end() .find( 'select.preference' ).change( mark_modified ); -- 1.9.1