From 941af0b8c84049ef85f3e5dfc712fd54678b3b7e Mon Sep 17 00:00:00 2001 From: Aleisha Date: Wed, 29 Apr 2015 01:56:45 +0000 Subject: [PATCH] Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc This match sets $sortby (previously undefined value) as an empty string to get rid of the warns. To test: 1) Go to a URL such as http://localhost:8080/cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operator=contains&value=a&marclist=any&and_or=and 2) Notice the warns in the error log 3) Apply patch 4) Reload URL 5) Notice page still works but no warns in error log Signed-off-by: Mark Tompsett NOTE: I would have done $sortby //= ''; But this works too. :) Signed-off-by: Jonathan Druart --- C4/AuthoritiesMarc.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/C4/AuthoritiesMarc.pm b/C4/AuthoritiesMarc.pm index 03b0b51..c311fb2 100644 --- a/C4/AuthoritiesMarc.pm +++ b/C4/AuthoritiesMarc.pm @@ -109,6 +109,7 @@ sub SearchAuthorities { my ($tags, $and_or, $excluding, $operator, $value, $offset,$length,$authtypecode,$sortby,$skipmetadata) = @_; # warn Dumper($tags, $and_or, $excluding, $operator, $value, $offset,$length,$authtypecode,$sortby); my $dbh=C4::Context->dbh; + $sortby="" unless $sortby; my $query; my $qpquery = ''; my $QParser; -- 2.1.0