Bugzilla – Attachment 38763 Details for
Bug 14121
Silence warnings t/db_dependent/Auth_with_cas.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14121: Silence warnings t/db_dependent/Auth_with_cas.t
Bug-14121-Silence-warnings-tdbdependentAuthwithcas.patch (text/plain), 1.27 KB, created by
Mark Tompsett
on 2015-05-02 04:33:25 UTC
(
hide
)
Description:
Bug 14121: Silence warnings t/db_dependent/Auth_with_cas.t
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2015-05-02 04:33:25 UTC
Size:
1.27 KB
patch
obsolete
>From 44cb319f69236cb36dbdd4da66800806e1f4eb43 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Sat, 2 May 2015 00:31:14 -0400 >Subject: [PATCH] Bug 14121: Silence warnings t/db_dependent/Auth_with_cas.t > >TEST PLAN >--------- >1) $ prove t/db_dependent/Auth_with_cas.t > -- CGI security warning >2) apply patch >3) $ prove t/db_dependent/Auth_with_cas.t > -- no noise. >4) koha qa test tools >--- > C4/Auth_with_cas.pm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/C4/Auth_with_cas.pm b/C4/Auth_with_cas.pm >index 2cccebe..71026e3 100644 >--- a/C4/Auth_with_cas.pm >+++ b/C4/Auth_with_cas.pm >@@ -211,10 +211,11 @@ sub _url_with_get_params { > foreach ( $query->url_param() ) { > # url_param() always returns parameters that were deleted by delete() > # This additional check ensure that parameter was not deleted. >- if ($query->param($_)) { >+ my $uriPiece = $query->param($_); >+ if ($uriPiece) { > $uri_params_part .= '&' if $uri_params_part; > $uri_params_part .= $_ . '='; >- $uri_params_part .= URI::Escape::uri_escape( $query->param($_) ); >+ $uri_params_part .= URI::Escape::uri_escape( $uriPiece ); > } > } > $uri_base_part .= '?' if $uri_params_part; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14121
:
38763
|
39621
|
40696
|
40936