Bugzilla – Attachment 38906 Details for
Bug 14116
Silence noise t/Scrubber.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 14116: Silence noisy output for t/Scrubber.
SIGNED-OFF-Bug-14116-Silence-noisy-output-for-tScr.patch (text/plain), 1.42 KB, created by
Bernardo Gonzalez Kriegel
on 2015-05-06 20:10:15 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 14116: Silence noisy output for t/Scrubber.
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2015-05-06 20:10:15 UTC
Size:
1.42 KB
patch
obsolete
>From 722f6f574136d139b4648fabb217478fb04084bb Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Fri, 1 May 2015 21:16:56 -0400 >Subject: [PATCH] [SIGNED-OFF] Bug 14116: Silence noisy output for t/Scrubber. > >Some diag's are better suited as prints. > >TEST PLAN >--------- >1) $ prove t/Scrubber.t > -- there's some noise. >2) apply patch >3) $ prove t/Scrubber.t > -- noise issue resolved. > Output is still reasonable for -v. >4) koha qa test tools > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Works, no koha-qa errors >--- > t/Scrubber.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/Scrubber.t b/t/Scrubber.t >index 0fe3a60..08642fe 100755 >--- a/t/Scrubber.t >+++ b/t/Scrubber.t >@@ -44,7 +44,7 @@ At the end here, I actually have some regular text. > |; > > print pretty_line("Original HTML:"), $html, "\n", pretty_line(); >-$collapse and diag "Note: scrubber test output will have whitespace collapsed for readability\n"; >+$collapse and print "Note: scrubber test output will have whitespace collapsed for readability\n"; > ok($scrubber = C4::Scrubber->new(), "Constructor: C4::Scrubber->new()"); > > isa_ok($scrubber, 'HTML::Scrubber', 'Constructor returns HTML::Scrubber object'); >@@ -85,4 +85,4 @@ pass("Test should have failed on entry of 'Client' and it did. YAY!\n"); > > print "######################################################\n"; > >-diag "done.\n"; >+print "done.\n"; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14116
:
38757
|
38906
|
39615
|
39616
|
39617
|
39619
|
39694