Bugzilla – Attachment 39010 Details for
Bug 13673
Remove warnings from t/db_dependent/Barcodes.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t
Bug-13673-Silence-noisy-warnings-in-tdbdependentBa.patch (text/plain), 4.75 KB, created by
Indranil Das Gupta
on 2015-05-10 05:17:46 UTC
(
hide
)
Description:
Bug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t
Filename:
MIME Type:
Creator:
Indranil Das Gupta
Created:
2015-05-10 05:17:46 UTC
Size:
4.75 KB
patch
obsolete
>From 3927568adc79fa8e218410ec39e33a26692e700b Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Fri, 8 May 2015 17:16:53 -0400 >Subject: [PATCH] Bug 13673: Silence noisy warnings in > t/db_dependent/Barcodes.t > >This last patch catches all the warning messages in tests. > >TEST PLAN >--------- >1) Apply first two patches >2) $ prove t/db_dependent/Barcodes.t > -- still noisy warnings. >3) apply last patch >4) $ prove t/db_dependent/Barcodes.t > -- All noisy warnings are caught. >5) koha qa test tools. > >Signed-off-by: Indranil Das Gupta <indradg@gmail.com> >--- > t/db_dependent/Barcodes.t | 54 +++++++++++++++++++++++++++++++++++++++++------ > 1 file changed, 48 insertions(+), 6 deletions(-) > >diff --git a/t/db_dependent/Barcodes.t b/t/db_dependent/Barcodes.t >index 7e00649..2d69485 100755 >--- a/t/db_dependent/Barcodes.t >+++ b/t/db_dependent/Barcodes.t >@@ -1,9 +1,11 @@ > #!/usr/bin/perl > >-use strict; >-use warnings; >+use Modern::Perl; >+use Test::More tests => 73; >+use Test::Warn; >+ >+$| = 1; > >-use Test::More tests => 66; > BEGIN { > use FindBin; > use lib $FindBin::Bin; >@@ -21,12 +23,40 @@ my ($obj1,$obj2,$format,$value,$initial,$serial,$re,$next,$previous,$temp); > my @formats = sort keys %thash; > foreach (@formats) { > my $pre = sprintf '(%-12s)', $_; >- ok($obj1 = C4::Barcodes->new($_), "$pre Barcode Creation : new($_)"); >+ if ($_ eq 'EAN13') { >+ warning_like { $obj1 = C4::Barcodes->new($_); } >+ [ qr/not valid EAN-13 barcode/ ], >+ "$pre Expected complaint regarding $_ not being a valid EAN-13 barcode"; >+ } >+ elsif ($_ eq 'annual') { >+ warning_like { $obj1 = C4::Barcodes->new($_); } >+ [ qr/No max barcode (.*) found\. Using initial value\./ ], >+ "$pre Expected complaint regarding no max barcode found"; >+ } >+ elsif ($_ eq 'hbyymmincr') { >+ warning_like { $obj1 = C4::Barcodes->new($_); } >+ [ qr/No existing hbyymmincr barcodes found\. Reverting to initial value\./ ], >+ "$pre Expected complaint regarding no hbyymmincr barcodes found"; >+ } >+ elsif ($_ eq 'incremental') { >+ $obj1 = C4::Barcodes->new($_); >+ } >+ else { >+ die "This should not happen! ($_)\n"; >+ } >+ ok($obj1, "$pre Barcode Creation : new($_)"); > SKIP: { > skip "No Object Returned by new($_)", 17 unless $obj1; > ok($_ eq ($format = $obj1->autoBarcode()), "$pre autoBarcode() : " . ($format || 'FAILED') ); > ok($initial= $obj1->initial(), "$pre initial() : " . ($initial|| 'FAILED') ); >- $temp = $obj1->db_max(); >+ if ($_ eq 'hbyymmincr') { >+ warning_like { $temp = $obj1->db_max(); } >+ [ qr/No existing hbyymmincr barcodes found\. Reverting to initial value\./ ], >+ "$pre Expected complaint regarding no hbyymmincr barcodes found"; >+ } >+ else { >+ $temp = $obj1->db_max(); >+ } > ok($temp = $obj1->max(), "$pre max() : " . ($temp || 'FAILED') ); > ok($value = $obj1->value(), "$pre value() : " . ($value || 'FAILED') ); > ok($serial = $obj1->serial(), "$pre serial() : " . ($serial || 'FAILED') ); >@@ -45,12 +75,24 @@ foreach (@formats) { > foreach $format (@formats) { > my $pre = sprintf '(%-12s)', $format; > foreach my $testval (@{$thash{ $format }}) { >- ok($obj1 = C4::Barcodes->new($format,$testval), "$pre Barcode Creation : new('$format','$testval')"); > if ($format eq 'hbyymmincr') { >+ warning_like { $obj1 = C4::Barcodes->new($format,$testval); } >+ [ qr/No existing hbyymmincr barcodes found\. Reverting to initial value\./ ], >+ "$pre Expected complaint regarding no hbyymmincr barcodes found"; >+ ok($obj1, "$pre Barcode Creation : new('$format','$testval')"); > $obj2 = $obj1->new(); > my $branch; > ok($branch = $obj1->branch(), "$pre branch() : " . ($branch || 'FAILED') ); > ok($branch eq $obj2->branch(), "$pre branch extended to derived object : " . ($obj2->branch || 'FAILED')); > } >+ elsif ($format eq 'EAN13') { >+ warning_like { $obj1 = C4::Barcodes->new($format,$testval) } >+ [ qr/not valid EAN-13 barcode/ ], >+ "$pre Expected complaint regarding $testval not being a valid EAN-13 barcode"; >+ ok($obj1, "$pre Barcode Creation : new('$format','$testval')"); >+ } >+ else { >+ ok($obj1 = C4::Barcodes->new($format,$testval), "$pre Barcode Creation : new('$format','$testval')"); >+ } > } > } >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13673
:
38995
|
38996
|
38997
|
38998
|
39000
|
39001
|
39002
|
39003
|
39004
|
39005
|
39006
|
39010
|
39011
|
39012
|
39013
|
39220
|
39221
|
39222
|
39223