Bugzilla – Attachment 39015 Details for
Bug 14112
Silence warnings t/Charset.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14112: Silence warnings in t/Charset.t
Bug-14112-Silence-warnings-in-tCharsett.patch (text/plain), 1.23 KB, created by
Indranil Das Gupta
on 2015-05-10 08:23:04 UTC
(
hide
)
Description:
Bug 14112: Silence warnings in t/Charset.t
Filename:
MIME Type:
Creator:
Indranil Das Gupta
Created:
2015-05-10 08:23:04 UTC
Size:
1.23 KB
patch
obsolete
>From 98b098263d847ef2c4095fdada18ad6575349057 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Fri, 1 May 2015 15:49:12 -0400 >Subject: [PATCH] Bug 14112: Silence warnings in t/Charset.t > >Running prove on t/Charset.t had a complaint about a better way >to write \c3. This suppresses it. > >TEST PLAN >--------- >1) $ prove t/Charset.t > -- get a warning >2) apply patch >3) $ prove t/Charset.t >4) run koha qa test tools > >Signed-off-by: Indranil Das Gupta <indradg@gmail.com> >--- > t/Charset.t | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/t/Charset.t b/t/Charset.t >index 09ba533..e0c2f32 100755 >--- a/t/Charset.t >+++ b/t/Charset.t >@@ -41,7 +41,11 @@ ok(defined(NormalizeString($string,1,1)), 'Initialized string case 4 normali > my $octets = "abc"; > ok(IsStringUTF8ish($octets), "verify octets are valid UTF-8 (ASCII)"); > >-$octets = "flamb\c3\a9"; >+{ >+ no warnings 'syntax'; >+ $octets = "flamb\c3\a9"; >+} >+ > ok(!Encode::is_utf8($octets), "verify that string does not have Perl UTF-8 flag on"); > ok(IsStringUTF8ish($octets), "verify octets are valid UTF-8 (LATIN SMALL LETTER E WITH ACUTE)"); > ok(!Encode::is_utf8($octets), "verify that IsStringUTF8ish does not magically turn Perl UTF-8 flag on"); >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14112
:
38753
|
39014
|
39015
|
39406
|
39545
|
39570