From 4cea54f48b5e1db693a556a152ef9b18146a05db Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Wed, 13 May 2015 16:05:24 -0400 Subject: [PATCH] Bug 14076: silence warnings in opac/opac-authorities-home.pl TEST PLAN --------- 1) Blank your koha opac error log file 2) Open your OPAC 3) Click 'Authority search' 4) Click 'Submit' 5) Review the koha opac error log file -- the end should have messages about security vunerabilities because CGI param is used in a list context. 6) blank your koha opac error log file 7) apply patch 8) repeat steps 2-5 -- this time, those security warnings should be gone. -- if you see an oAuth error, that's because you have no authority records and the search failed as a result. 9) run koha qa test tools. --- opac/opac-authorities-home.pl | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/opac/opac-authorities-home.pl b/opac/opac-authorities-home.pl index 54c1444..a029f62 100755 --- a/opac/opac-authorities-home.pl +++ b/opac/opac-authorities-home.pl @@ -59,12 +59,12 @@ foreach my $thisauthtype ( } if ( $op eq "do_search" ) { - my @marclist = ($query->param('marclist')); - my @and_or = ($query->param('and_or')); - my @excluding = ($query->param('excluding'),); - my @operator = ($query->param('operator')); - my $orderby = $query->param('orderby'); - my @value = ($query->param('value') || "",); + my @marclist = $query->multi_param('marclist'); + my @and_or = $query->multi_param('and_or'); + my @excluding = $query->multi_param('excluding'); + my @operator = $query->multi_param('operator'); + my $orderby = $query->param('orderby'); + my @value = $query->multi_param('value'); $resultsperpage = $query->param('resultsperpage'); $resultsperpage = 20 if ( !defined $resultsperpage ); -- 2.1.4