From b86b8760d09c86b5abe701fe6464767823d4af46 Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Sat, 18 Apr 2015 15:44:56 -0400 Subject: [PATCH] [SIGNED-OFF] Bug 8688: Update License, Perlcritic -3 friendly This patch tweaks the license information to v3, as per the license found in the Coding Guidelines on the wiki: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence This also changes: use strict; use warnings; into: use Modern::Perl; As per the PERL2: Modern::Perl requirement in the Guidelines: http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL2:_Modern::Perl And though the guidelines only require perlcritic -5, a single line tweak gets a bump to perlcritic -3. TEST PLAN --------- 1) perlcritic -5 circ/send_recall_notice.pl -- success, so technically no change was required. 2) perlcritic -3 circ/send_recall_notice.pl -- fails 3) apply patch 4) perlcritic -3 circ/send_recall_notice.pl -- success 5) run koha qa test tools Signed-off-by: Bernardo Gonzalez Kriegel --- circ/send_recall_notice.pl | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/circ/send_recall_notice.pl b/circ/send_recall_notice.pl index bbc6e73..4e7f1a5 100644 --- a/circ/send_recall_notice.pl +++ b/circ/send_recall_notice.pl @@ -1,24 +1,23 @@ #!/usr/bin/perl -# Author : Frédérick Capovilla, 2011 - SYS-TECH -# # This file is part of Koha. # -# Koha is free software; you can redistribute it and/or modify it under the -# terms of the GNU General Public License as published by the Free Software -# Foundation; either version 2 of the License, or (at your option) any later -# version. +# Copyright (C) 2011 Frédérick Capovilla, SYS-TECH +# +# Koha is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. # -# Koha is distributed in the hope that it will be useful, but WITHOUT ANY -# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR -# A PARTICULAR PURPOSE. See the GNU General Public License for more details. +# Koha is distributed in the hope that it will be useful, but +# WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. # -# You should have received a copy of the GNU General Public License along -# with Koha; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +# You should have received a copy of the GNU General Public License +# along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; use C4::Message; use C4::Circulation; @@ -27,7 +26,7 @@ use C4::Auth; use CGI; use CGI::Cookie; -my $input = new CGI; +my $input = CGI->new; my $itemnumber = $input->param('itemnumber'); # Check the user's permissions -- 1.9.1